Skip to content

Add two new simulation visualizations to homepage#1392

Merged
sbryngelson merged 4 commits intoMFlowCode:masterfrom
sbryngelson:add-new-simulations
May 1, 2026
Merged

Add two new simulation visualizations to homepage#1392
sbryngelson merged 4 commits intoMFlowCode:masterfrom
sbryngelson:add-new-simulations

Conversation

@sbryngelson
Copy link
Copy Markdown
Member

@sbryngelson sbryngelson commented May 1, 2026

Adds two new simulation cards to the Featured Simulations grid on the homepage.

Sphere-sphere collision and wall rebound (Fundamentals section)

Shock — 1,000 grid-resolved particles (Shock-droplet section)

Thumbnails pulled from YouTube (docs/res/simulations/w.jpg and x.jpg).

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 1, 2026 •
edited
Loading

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Remediation recommended

1. Missing noopener on links 🐞 Bug ⛨ Security
Description 
The new simulations add additional external source URLs that are rendered into `<a
target="_blank"> links without rel="noopener noreferrer"`, allowing the opened page to access
window.opener (reverse-tabnabbing). This is a pre-existing pattern in the template, but this PR
expands exposure by adding more external links.
Code

docs/index.html[61]

+            { name: "Shock — 1,000 grid-resolved particles",  image: "res/simulations/x.jpg", computer: "Phoenix",    computerUrl: "https://www.pace.gatech.edu/",                                                 accelerators: "4 A100s",   walltime: "~1.5h", source: "https://www.youtube.com/watch?v=ufisHG0KkOU" },
Evidence 
The newly added simulation entries include external source URLs. The page renders s.source into
an anchor with target="_blank" but without rel="noopener noreferrer"; similarly, s.computerUrl
is rendered into a target="_blank" anchor without rel, enabling reverse-tabnabbing for any
clicked external link.

docs/index.html[61-61]
docs/index.html[78-78]
docs/index.html[85-104]

Agent prompt 
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Simulation cards open external links in a new tab via `target="_blank"` without `rel="noopener noreferrer"`, which allows reverse-tabnabbing through `window.opener`.
### Issue Context
This is a pre-existing rendering pattern, but the PR adds more external `source` links (and the cards also render `computerUrl` similarly), expanding exposure.
### Fix Focus Areas
- docs/index.html[96-99]
- docs/index.html[103-103]
### Implementation notes
Add `rel="noopener noreferrer"` to the `<a ... target="_blank">` used for `s.source`, and to the conditional `<a ... target="_blank">` used for `s.computerUrl`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Grey Divider

Previous review results

Review updated until commit f2ada2c

Results up to commit f2ada2c


🐞 Bugs (1) 📘 Rule violations (0)


Remediation recommended
1. Missing noopener on links 🐞 Bug ⛨ Security
Description 
The new simulations add additional external source URLs that are rendered into `<a
target="_blank"> links without rel="noopener noreferrer"`, allowing the opened page to access
window.opener (reverse-tabnabbing). This is a pre-existing pattern in the template, but this PR
expands exposure by adding more external links.
Code

docs/index.html[61]

+            { name: "Shock — 1,000 grid-resolved particles",  image: "res/simulations/x.jpg", computer: "Phoenix",    computerUrl: "https://www.pace.gatech.edu/",                                                 accelerators: "4 A100s",   walltime: "~1.5h", source: "https://www.youtube.com/watch?v=ufisHG0KkOU" },
Evidence 
The newly added simulation entries include external source URLs. The page renders s.source into
an anchor with target="_blank" but without rel="noopener noreferrer"; similarly, s.computerUrl
is rendered into a target="_blank" anchor without rel, enabling reverse-tabnabbing for any
clicked external link.

docs/index.html[61-61]
docs/index.html[78-78]
docs/index.html[85-104]

Agent prompt 
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Simulation cards open external links in a new tab via `target="_blank"` without `rel="noopener noreferrer"`, which allows reverse-tabnabbing through `window.opener`.

### Issue Context
This is a pre-existing rendering pattern, but the PR adds more external `source` links (and the cards also render `computerUrl` similarly), expanding exposure.

### Fix Focus Areas
- docs/index.html[96-99]
- docs/index.html[103-103]

### Implementation notes
Add `rel="noopener noreferrer"` to the `<a ... target="_blank">` used for `s.source`, and to the conditional `<a ... target="_blank">` used for `s.computerUrl`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Qodo Logo

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 922336be-9938-4e52-9edb-8a49de2326f4

📥 Commits

Reviewing files that changed from the base of the PR and between a314b0b and f2ada2c.

⛔ Files ignored due to path filters (2)
  • docs/res/simulations/w.jpg is excluded by !**/*.jpg
  • docs/res/simulations/x.jpg is excluded by !**/*.jpg
📒 Files selected for processing (1)
  • docs/index.html
📝 Walkthrough

Walkthrough

Two new featured simulation cards are added to the simulation array in the documentation index. Each card object includes a simulation title, thumbnail image, compute system metadata, accelerator count, walltime string, and a link source. These new entries will be rendered in the front-end alongside existing simulation cards. No public or exported entities were modified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides clear details about the two new simulations, their specifications, and resources, but lacks the required PR template structure with sections for type of change, testing, and checklist. Format the description to follow the repository's PR template, including sections for Type of change, Testing, and Checklist to ensure consistency with project standards.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding two new simulation visualizations to the homepage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 1, 2026 •
edited
Loading

Persistent review updated to latest commit f2ada2c

@sbryngelson sbryngelson merged commit 92e3124 into MFlowCode:master May 1, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sbryngelson